#012329: ezcBaseFeatures::findExecutableInPath wrong return value under windows

Description:

File:
Base\src\features.php

Lines
314-317
if ( file_exists( "{$dir}\\{$fileName}.exe" ) )
{

return "{$dir}\\{$fileName}";
}

this should be
if ( file_exists( "{$dir}\\{$fileName}.exe" ) )
{

return "{$dir}\\{$fileName}.exe";
}

added .exe to the return value because other wise its useless

Environment:

Operating System:
PHP Version: (please be specific, like '4.4.3' or '5.1.5')
Database and version:
Browser (and version):

Attachments

No attachments for this issue.

Comments

Why is it useless? You can still call it just fine. And that's the idea of this function... find an executable in the path so that you can execute it.

#255344 by Derick Rethans on January 8th, 2008 [Permanent Link]

Hi Derick,

youre right. its ok to return the name without .exe but if you check for .exe you should also return it. because if i have a identify binary in my path without the .exe at the same place it fails.

c:\programme\imagemagick-6.3.7-q16\identify
can be different than
c:\programme\imagemagick-6.3.7-q16\identify.exe

#255345 by Marco Kaiser on January 8th, 2008 [Permanent Link]

Fixed in rev. 7103.

#255350 by Derick Rethans on January 8th, 2008 [Permanent Link]

Links

No links for this issue.

History

Load History

Properties

Type		Bug

Priority		Medium

Component		Components » Base

Affects		Unknown

Fix Version		2007.2.1 - eZ components 2007.2.1

Reporter		Marco Kaiser

Responsible		Derick Rethans

Status		Closed

Resolution		Fixed

Created		January 7th, 2008

Updated		January 8th, 2008

Resolved		January 8th, 2008