#015748: generator tag in atom feed invalid

Description:

Creating an atom feed with ezcFeed gives:


<generator>eZ Components Feed<version>1.2.1</version><uri>http://ezcomponents.org/docs/tutorials/Feed</uri></generator>

but it needs to be:


<generator version="dev" uri="http://ezcomponents.org/docs/tutorials/Feed">eZ Components Feed</generator>

Patch:


--- a/Feed/src/processors/atom.php
+++ b/Feed/src/processors/atom.php
@@ -438,12 +438,12 @@ class ezcFeedAtom extends ezcFeedProcessor implements ezcFeedParser

         if ( $version !== null )
         {
-            $this->generateMetaData( $elementTag, 'version', $version );
+            $this->addAttribute( $elementTag, 'version', $version );
         }

         if ( $url !== null )
         {
-            $this->generateMetaData( $elementTag, 'uri', $url );
+            $this->addAttribute( $elementTag, 'uri', $url );
         }
     }

Environment:

Operating System:
PHP Version: (please be specific, like '4.4.3' or '5.1.5')
Database and version:
Browser (and version):


- Attachments
feed_generator.diff (656 b)
[Download] [Permanent Link]

- Comments

Fixed in revision 11036.

#263739 by Derick Rethans on November 5th, 2009 [Permanent Link]

- History
Properties
Type Bug
Priority Medium
Component Components » Feed
Affects Unknown
Fix Versions 2009.2 sprint 3 - eZ components 2009.2 sprint 3
2009.2alpha1 - eZ components 2009.2alpha1
Reporter Thomas Koch
Responsible Derick Rethans
Status 0 Closed
Resolution Fixed
Created November 4th, 2009
Updated November 5th, 2009
Resolved November 5th, 2009
 
Navigation [Permanent Link]
Previous Issue
Back to Issues List
Next Issue: #015537
  Graph shows to small and truncated rotated axis labels