#014797: Optimize common.php and other commonly used functions

And perhaps replace is_null( $foobar ) by $foobar === null ?

#261313 by Damien POBEL on April 20th, 2009 [Permanent Link]

And perhaps check the use of preg_* functions. On the homepage of an admin interface (with already generated caches), I have about 96 calls to a preg_* function.

Looking quickly at the code, I think that some preg_* functions calls can be improved or replaced, for instance:

• in access.php:321, preg_replace is used to replace / by \/, str_replace would far more efficient
• in eZDir::cleanPath() (called 67 times on the cached homepage of my admin), preg_replace is used to replace double (or more) directory separators by one, I think that a test to check if a double separator is there with strpos() could avoid a lot of preg_replace call and would be more efficient (having a double separator or more seems to be a quite rare case).

#261314 by Damien POBEL on April 21st, 2009 [Permanent Link]

Anybody knows the reason for usage of the 'foreach( array_key( $somevar ) as $key )' construct btw?

#261396 by Gaetano Giunta on April 26th, 2009 [Permanent Link]

Look into using mt_rand() instead of rand().

ref php doc:
"It uses a random number generator with known characteristics using the » Mersenne Twister, which will produce random numbers four times faster than what the average libc rand() provides."

#261414 by André R. on April 27th, 2009 [Permanent Link]

So far implemented in trunk
Optimize eZINI::instance and eZINI->variable in Rev. 23519
Change / avoid preg_replace calls ezdir and access.php in Rev. 23520
array_key_exists -> isset autoload.php in Rev. 23521
is_null -> === null in Rev. 23522
Removed 2 redundant eZINI::instance calls from index.php in Rev. 23523
array_key_exists -> isset ezdebug.php in Rev. 23524
Make eZINI->assign use internal data instead of public api in Rev. 23525
Make eZINI->variableArray use internal data instead of public api in Rev. 23526

#261482 by André R. on May 6th, 2009 [Permanent Link]

Proposed pattern to reduce calls to eZINI::instance and eZDir::path

Index: index.php
===================================================================
--- index.php    (revision 23526)
+++ index.php    (working copy)
@@ -152,7 +152,7 @@
 list( $iniFilePermission, $iniDirPermission ) =
     $ini->variableMulti( 'FileSettings', array( 'StorageFilePermissions', 'StorageDirPermissions' ) );
 
-$iniVarDirectory = eZSys::cacheDirectory() ;
+$iniVarDirectory = eZSys::cacheDirectory( false ) ;
 
 // OPTIMIZATION:
 // Sets permission array as global variable, this avoids the eZCodePage include
Index: lib/ezutils/classes/ezsys.php
===================================================================
--- lib/ezutils/classes/ezsys.php    (revision 23526)
+++ lib/ezutils/classes/ezsys.php    (working copy)
@@ -453,19 +453,31 @@
      \return the directory used for storing cache files.
      \note This will include the varDirectory().
     */
-    static function cacheDirectory()
+    static function cacheDirectory( $allowCachingPath = true )
     {
-        $ini = eZINI::instance();
+        static $staticCacheDir = null;
+
+        if ( $staticCacheDir !== null && $allowCachingPath === true  )
+        {
+            return $staticCacheDir;
+        }
+
+        $ini = eZINI::instance();
         $cacheDir = $ini->variable( 'FileSettings', 'CacheDir' );
 
-        if ( $cacheDir[0] == "/" )
+        if ( $cacheDir[0] === '/' )
         {
-            return eZDir::path( array( $cacheDir ) );
+            $cacheDir = eZDir::path( array( $cacheDir ) );
         }
         else
         {
-            return eZDir::path( array( eZSys::varDirectory(), $cacheDir ) );
+            $cacheDir = eZDir::path( array( eZSys::varDirectory(), $cacheDir ) );
         }
+        if ( $allowCachingPath === true  )
+        {
+            $staticCacheDir = $cacheDir;
+        }
+        return $cacheDir;
     }
 
     /*!

#261483 by André R. on May 7th, 2009 [Permanent Link]

Attached patch avoids about 10000 (!) preg_match calls after clearing all caches.

#261527 by Damien POBEL on May 9th, 2009 [Permanent Link]

Optimization for eZPersistentObject classes ::definition() calls.

#261536 by André R. on May 11th, 2009 [Permanent Link]

In addition, after clearing all caches, it seems that there are a lots of calls to eZDir::recursiveFindRelative() (so a lot of opendir/readdir/preg_match calls) because the complete list of templates through all designs and all extensions is build several times during the execution of the page. With a quick and dirty in memory cache in eZTemplateDesignResource::overrideArray(), the home page of my back office takes 12 seconds to be generated after a clearing all caches, without it, it takes about 18 seconds !

#261588 by Damien POBEL on May 13th, 2009 [Permanent Link]

Small stuff in common.php, should also look into the merging the function_exists calls or remove them (the compiled templates both check presence of constant and use include_once so shouldn't need them), and benchmark defined() vs other means of knowing that file is loaded (global for instance), or just move these functions to a class that is loaded anyway and call them statically.

Index: eztemplatecompiler.php
--- eztemplatecompiler.php Base (BASE)
+++ eztemplatecompiler.php Locally Modified (Based On LOCAL)
@@ -1932,9 +1932,7 @@
 $lbracket
     function compiledFetchVariable( \$vars, \$namespace, \$name )
     $lbracket
-        \$exists = ( array_key_exists( \$namespace, \$vars ) and
-                    array_key_exists( \$name, \$vars[\$namespace] ) );
-        if ( \$exists )
+        if ( isset( \$vars[\$namespace][\$name] ) )
         $lbracket
             return \$vars[\$namespace][\$name];
         $rbracket
@@ -1970,8 +1968,8 @@
     $lbracket
         if ( is_object( \$value ) )
         $lbracket
-            if ( method_exists( \$value, \"attribute\" ) and
-                 method_exists( \$value, \"hasattribute\" ) )
+            if ( method_exists( \$value, 'attribute' ) and
+                 method_exists( \$value, 'hasattribute' ) )
             $lbracket
                 if ( \$value->hasAttribute( \$attributeValue ) )
                 $lbracket

#262127 by André R. on June 30th, 2009 [Permanent Link]

Implemented in
trunk (4.2.0Alpha1) see above for the various revisions.

#263578 by André R. on October 16th, 2009 [Permanent Link]